Refactoring lazy initialization for model metadata #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi nate, I saw you have already implemented the lazy initialization for model metadata, sorry for the delay.
In this PR you will find my acutal "state" for this subject (from your implementation).
Using $_meta in closures is imo not safe since $_meta may contains in the same time initialized and not yet initialized metadata. Since the initialization is done lazily the order of initialization may produce different results. I also updated the autoConfig and added some tests.
Example of use :